-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent key names for same properties #61
Comments
Small change, but would need to look across DS to find instances of this |
We need to decide what naming convention we want to implement. Also it would be good to add the list of components impacted by this change during our tech session. |
Investigate the components that have these param in the DS and make a list of them alongside the params they use. We will then use this information to make a decision on which way we want to go with it in a tech session. |
To be started after the unnecessary conditionals work ONSdigital/design-system#3013 to ONSdigital/design-system#3026. |
Components with inconsistencies
|
Within the design system there is an inconsistent approach to naming keys. i.e.
When dealing with a component that has a some text and a href (nav, service nav, language etc) we don't use the same name conventions. Navigation uses
title
andpath
and service navigation usestext
andurl
.We need to review and update so we use consistent key names.
The text was updated successfully, but these errors were encountered: