Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macro tests to allow running of specific tests #3361

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 18, 2024

What is the context of this PR?

Fixes: #3362

We should adopt this syntax for writing our FORs in our macro tests. This will allow us to continue to have the option to run just the tests for one component, all the tests, just the script tests and just the macro tests. This is what we have currently as shown here in the readme.

Screenshot 2024-09-18 at 15 15 39

How to review this PR

Try running the header tests locally using this syntax
yarn test --testNamePattern="FOR: Macro: Header"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 87fd10c
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66f16fcc78ae0f0008007567
😎 Deploy Preview https://deploy-preview-3361--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar self-assigned this Sep 18, 2024
@rmccar rmccar requested a review from a team September 18, 2024 15:45
@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 18, 2024
@rmccar rmccar changed the title Update header tests to allow running of specific tests Update macro tests to allow running of specific tests Sep 19, 2024
@rmccar rmccar merged commit 63ca1b4 into main Sep 24, 2024
42 checks passed
@rmccar rmccar deleted the update-header-tests-allow-running-specific-tests branch September 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update header macro tests to allow running of specific tests
3 participants