Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Breadcrumbs component test file to new format #3342

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

balibirchlee
Copy link
Contributor

@balibirchlee balibirchlee commented Sep 12, 2024

What is the context of this PR?

Fixes #137 on the design system team board

How to review this PR

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?
  • run this test command to view the test results:
  • yarn test --testNamePattern="FOR: Macro: Breadcrumbs"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@balibirchlee balibirchlee added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 12, 2024
@balibirchlee balibirchlee requested a review from a team September 12, 2024 10:09
@balibirchlee balibirchlee self-assigned this Sep 12, 2024
@balibirchlee balibirchlee linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit ec3ec6b
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66e2bdef3ff2c9000853b0bf
😎 Deploy Preview https://deploy-preview-3342--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit bb4788f
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66f6c31fe4c1a8000897ea21
😎 Deploy Preview https://deploy-preview-3342--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV merged commit 6afaba9 into main Sep 30, 2024
42 checks passed
@SriHV SriHV deleted the enhancement/137/testing-refactor-breadcrumbs branch September 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing refactor - Breadcrumbs
4 participants