Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move foundation examples to Components folder #3278

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Jul 30, 2024

What is the context of this PR?

Fixes ONSdigital/design-team#52
It relocates the examples of list, quote, text-indent, and address output from the foundations folder to the component folder. This change ensures that the macro options file and examples file are co-located for easier accessibility. Additionally, the grid examples have been moved and a new folder has been created for them.

How to review this PR

Verify that all tests and visual tests have been updated correctly.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team July 30, 2024 08:11
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 2b390c9
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66b5e1817e752c00083d9aad
😎 Deploy Preview https://deploy-preview-3278--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Jul 30, 2024
Copy link
Contributor

@alessioventuriniAND alessioventuriniAND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run the reference command for the visual regression tests? It will remove all the old references that are not longer needed like all the screenshots of the same component but with the old name.

@alessioventuriniAND alessioventuriniAND self-requested a review August 6, 2024 08:48
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 2f6fc25 into main Aug 9, 2024
8 of 9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/52/move-foundation-examples-to-component-folder branch August 9, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nunjacks macro option in all components in Foundation
4 participants