-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move foundation examples to Components folder #3278
Move foundation examples to Components folder #3278
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
...itmaps_reference/ds-vr-test__components_helpers_grid_example-grid-8_0_document_0_desktop.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also run the reference command for the visual regression tests? It will remove all the old references that are not longer needed like all the screenshots of the same component but with the old name.
What is the context of this PR?
Fixes ONSdigital/design-team#52
It relocates the examples of list, quote, text-indent, and address output from the foundations folder to the component folder. This change ensures that the macro options file and examples file are co-located for easier accessibility. Additionally, the grid examples have been moved and a new folder has been created for them.
How to review this PR
Verify that all tests and visual tests have been updated correctly.
Checklist
This needs to be completed by the person raising the PR.