Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed backlink component #3276

Merged

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Jul 23, 2024

What is the context of this PR?

Fixes ONSdigital/design-team#49.

This PR removes the backlink component form the DS project.

How to review this PR

Check that all references to the backlink component are removed

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Breaking changes This PR contains at least one breaking change label Jul 23, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team July 23, 2024 12:02
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit f793e25
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66b09fd2ef1c930008826e4c
😎 Deploy Preview https://deploy-preview-3276--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title remove backlink component Removed backlink component Jul 23, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons added Tech improvements Tech debt, cleanup, code standardisation etc. and removed Breaking changes This PR contains at least one breaking change labels Jul 24, 2024
Copy link
Contributor

@alessioventuriniAND alessioventuriniAND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with you , I am happy for this to be removed but we need to know what to do with the content that we currently have in the backlink entry on the service manual.
Once you have confirmation for Joe we might need a ticket for the service manual to target this change when this change is released :)

@alessioventuriniAND alessioventuriniAND self-requested a review July 26, 2024 09:33
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 5bcd4f4 into main Aug 5, 2024
8 of 9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/49/remove-backlink-component branch August 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Remove deprecated component - Backlink
4 participants