-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed metadata component #3275
Removed metadata component #3275
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the example listed in the body of the PR so that it looks like the below. No need to list all of the parameters as they are not changing, the only thing that is changing is the name of the component :
Click for example:
OLD
{% from "components/onsMetadata/_macro.njk" import onsMetadata %}
{{-
onsMetadata({ ... })
}}
NEW
{% from "components/description-list/_macro.njk" import onsDescriptionList %}
{{
onsDescriptionList({ ... })
}}
done |
* Standardise setting heading level across components #3111 * Update param names to camel case naming standard #3188 * Renamed utility class from ons-grid--flex to ons-grid-flex #3268 * Removed metadata component #3275 * Remove call to action component and all references #3143 * Update parameter from UnreadLink to UnreadLinkUrl in Message component #3290 * Update parameter subject from text to object type in Message list component #3291 * Add option for additional logo in footer #3227 * Update parameter from link to text in Footer Component #3294 * Update parameter name from url to src in Image Component #3293 * Update parameter names from LogoImage and LogoURL to image and url a in header component #3292 * Update parameter name from url to linkUrl in feedback component #3295 * Rename summary component parameters #3224 * Refactor timeline macro for compatibility with Jinja2 templates #3180 * Update parameter names in document list component #3299 * Update param name settingsLinkTextURL to settingsLinkURL in Cookies Banner component #3300 * Update parameter names in card component #3303 * Update parameter from linkText to text in external link component #3304 * Update param name from title to text in section navigation component #3305 * Update parameter from linkText to videoLinkText in Video Component #3306 * Update parameter from manualLink to manualLinkUrl in Address Input component #3307 * Ensure list item custom attributes are always set on list item #3336 * Rename items summary param for compatibility with Jinja #3382 * Update DS components to ensure compatibility with Jinja #3380 * Rename html OGL Link param to current naming standard #3379 * Format migration guide #3377 * Introduction of new spacing grid #3285
What is the context of this PR?
Fixes ONSdigital/design-team#48
This PR removes the Metadata component from the DS project.
Breaking Change
Description of change: The
onsMetadata
component has been removed.Reason for change: The component was removed as it has been replaced by the
descriptionList
component.Migration steps:
onsMetadata
in your codebase.onsMetadata
withonsDescriptionList
.Click for example:
How to review this PR
Check that all references to the metadata component has been removed
Checklist
This needs to be completed by the person raising the PR.