Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset value in a textarea within a radio #3257

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Jul 8, 2024

What is the context of this PR?

#3242... Added a preset value for a radio option that has textarea

How to review this PR

Add a preset value to one of the radio examples with a textarea option, and verify that the value is displayed.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@SriHV SriHV added the Enhancement Change of existing feature label Jul 8, 2024
@SriHV SriHV self-assigned this Jul 8, 2024
@SriHV SriHV linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 2de4796
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/668e933602c4b4000889fa74
😎 Deploy Preview https://deploy-preview-3257--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV requested a review from a team July 8, 2024 13:40
Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

src/components/radios/_macro.spec.js Outdated Show resolved Hide resolved
src/components/radios/_macro.spec.js Outdated Show resolved Hide resolved
src/components/radios/_macro.spec.js Outdated Show resolved Hide resolved
SriHV and others added 3 commits July 10, 2024 09:28
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
@alessioventuriniAND alessioventuriniAND force-pushed the enhancement/3242/add-pre-set-value-in-textara branch from 190964a to 6c2eca6 Compare July 10, 2024 10:39
@SriHV SriHV merged commit 2c2d7b9 into main Jul 11, 2024
9 checks passed
@SriHV SriHV deleted the enhancement/3242/add-pre-set-value-in-textara branch July 11, 2024 13:44
@rmccar rmccar changed the title Add Pre-set value in a textarea within a radio Add preset value in a textarea within a radio Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-set value to be available in a textarea within a radio
4 participants