Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sanitisedText from address mapping #3255

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Jul 5, 2024

What is the context of this PR?

Fixes ONSdigital/design-team#57

This PR removes the sanitisedText property from the addressMapping of the address-input component as it is not used.

How to review this PR

Verify that the sanitisedText property has been removed from the addressMapping in the address-input component.
Ensure the address-input component functions correctly.
Confirm that all tests are passing.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team July 5, 2024 10:20
@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Tech improvements Tech debt, cleanup, code standardisation etc. label Jul 5, 2024
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 70b4dc3
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/668e38b4a136e6000830b55f
😎 Deploy Preview https://deploy-preview-3255--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar changed the title remove sanitised test from adddress mapping Remove sanitised test from address mapping Jul 9, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit e949eae into main Jul 10, 2024
9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/remove-sanitised-text-mapping-from-address-mappinh branch July 10, 2024 08:47
@rmccar rmccar changed the title Remove sanitised test from address mapping Remove sanitised text from address mapping Jul 17, 2024
@rmccar rmccar changed the title Remove sanitised text from address mapping Remove sanitisedText from address mapping Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sanitisedText property returned from addressMapping of address-input component since it is never used
4 participants