Update incorrect link in address and change language patterns #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
We need to make the PR title and description a bit more descriptive and a bit more explanation of how to review. I haven't tested it in the service manual but the change seems to make no difference in the DS and the content of the Welsh example in the DS is all in Welsh already so is this a service manual issue? |
alessioventuriniAND
suggested changes
May 17, 2024
src/patterns/addresses/example-address-input-non-editable-confirm-address.njk
Outdated
Show resolved
Hide resolved
src/patterns/addresses/example-address-input-non-editable-register-address.njk
Outdated
Show resolved
Hide resolved
src/patterns/change-language/example-change-language-cymraeg.njk
Outdated
Show resolved
Hide resolved
src/patterns/change-language/example-change-language-english.njk
Outdated
Show resolved
Hide resolved
alessioventuriniAND
approved these changes
May 20, 2024
SriHV
approved these changes
May 21, 2024
adi-unni
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #3207 and #3208
This PR updates the links in the address and change language pattern examples
How to review this PR
Checklist
This needs to be completed by the person raising the PR.