Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus state link in footer #3167

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Apr 30, 2024

What is the context of this PR?

Fix: #3154

Fixed focus state link in footer which had a double line when hovered.

How to review this PR

Check that elements in footer doesn't have double line when focus is set and hovered

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit c4ec647
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66336c13ace1270008c07a33
😎 Deploy Preview https://deploy-preview-3167--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV changed the title changed hover state for ons-footer Fix focus state link in footer Apr 30, 2024
@SriHV SriHV added the Bug Something isn't working label Apr 30, 2024
@SriHV SriHV self-assigned this Apr 30, 2024
@SriHV SriHV requested a review from a team April 30, 2024 13:07
@SriHV SriHV marked this pull request as ready for review April 30, 2024 13:08
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@SriHV SriHV merged commit 8e702df into main May 2, 2024
9 checks passed
@SriHV SriHV deleted the fix/3154/fix-focus-state-link-in-footer branch May 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus state link in footer has a double line
6 participants