Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant for radios with a textarea #3148

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Apr 16, 2024

What is the context of this PR?

Fixes #3128

This PR adds a new variant and example of radios with text area.

How to review this PR

Spin up locally and check that the new example looks and works as expected, similar to the radio with input one

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Apr 16, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team April 16, 2024 15:03
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit df6f025
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/661fbe0b776be10008ec0bde
😎 Deploy Preview https://deploy-preview-3148--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title add variant for radios example variant for radios with text area Apr 16, 2024
Copy link
Contributor

@alessioventuriniAND alessioventuriniAND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the macro.md file with this new variant and link to the textarea docs for reference.

@rmccar rmccar changed the title example variant for radios with text area Add variant for radios with a textarea Apr 17, 2024
@precious-onyenaucheya-ons
Copy link
Contributor Author

We also need to update the macro.md file with this new variant and link to the textarea docs for reference.

updated

Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 4f0ae95 into main Apr 17, 2024
9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/3128-variant-for-radio-with-revealed-text-area branch April 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop variant to include the Textarea within the Radio with revealed input
4 participants