Add hidden context for icons in rows for summary tables #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
balibirchlee
approved these changes
Apr 15, 2024
alessioventuriniAND
approved these changes
Apr 16, 2024
rmccar
requested changes
Apr 16, 2024
rmccar
reviewed
Apr 16, 2024
|
Im a bit confused as to why the VR snapshots have been updated on this PR for the change to the width of radios that has just been merged in another PR. They should've been updated on the other PR. Ive already spoken to Alessio, we may need to look into our process of updating the snapshots on PRs and this could be the reason why we have been having problems with backstopJS recently. |
|
Cant fix the VR tests so have opened a new PR #3165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3030
This PR fixes the lack of context in summary tables where there is no status column and only an icon which in the case of the ticket, were checks for completion. Following from the DAC advice, we are now adding a visually hidden
<span>to the icon's<div>to enable adding additional contextual information. This done by setting the"iconVisuallyHiddenText": {string}param inrowItemsadjacent to"IconType": {icon}. The service can input the appropriate text to add context to whichever icon is being used.Please make sure that this param is set when there is no other context on the row indicating section completion status (see the new minimal example).
How to review this PR
Check the new example-minimal for the summary table and see if the new span tag with section completed is there. Sense check the output from the screen reader
Checklist
This needs to be completed by the person raising the PR.