Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed tab contents not wrapping on video example #3132

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Apr 10, 2024

What is the context of this PR?

Fixes #3121

This PR wraps the embed tab contents on video example so that users don't scroll sideways to read the text.

How to review this PR

Verify that the content in this example is wrapped properly

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Bug Something isn't working label Apr 10, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team April 10, 2024 06:47
@precious-onyenaucheya-ons precious-onyenaucheya-ons linked an issue Apr 10, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 84778db
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/661834c203ad41000852a601
😎 Deploy Preview https://deploy-preview-3132--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 06cfe69 into main Apr 12, 2024
9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the 3121-embed-tab-contents-not-wrapping-on-video-example branch April 12, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed tab contents not wrapping on video example
3 participants