Fix/411/sign language interpretation not available for video content wcag 22 level aaa #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Page template for length * Add macro * Add component foundations * Build stylesheet * Add additional functionality * Improved functionality * Fix border and layout * Fix resize behaviour * Changes to CSS * Add more tests * Update VR Tests * Change to full width --------- Co-authored-by: Alessio Venturini <112873190+alessioventuriniAND@users.noreply.github.com>
* initial change * update test * update test * update comment * update comment
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
approved these changes
Apr 3, 2024
precious-onyenaucheya-ons
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: https://github.com/ONSdigital/ons-service-manual-website/issues/398
Fixes: https://github.com/ONSdigital/ons-service-manual-website/issues/411
I have changed the video that we currently use in our tab-details component and video component. The old video failed two accessibility criteria as per the aforementioned issues.
This new video has sign language and doesn't need audio description.
How to review this PR
Confirm that the new video displays correctly.
Checklist
This needs to be completed by the person raising the PR.