Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/3022/explore unnecessary conditionals label #3108

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Enhancement/3022/explore unnecessary conditionals label #3108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
232e074
Changes in Documentation
SriHV Mar 19, 2024
a19d65e
removed conditionals for for
SriHV Mar 21, 2024
15e14ad
Merge branch 'main' into enhancement/3022/explore-unnecessary-conditi…
SriHV Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/label/_macro.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
{%- else -%}
<label
class="{% if params.inputType is not defined -%}ons-label{%- endif %}{{- ' ' + params.classes if params.classes else "" -}}{%- if params.description %} ons-label--with-description{%- endif %} {{- ' ons-label--placeholder' if params.accessiblePlaceholder else "" -}}"
for="{{ params.for }}"
{% if params.description %}aria-describedby="{{ descriptionID }}"{% endif %}
{% if params.for %} for="{{ params.for }}"{% endif %}
{% if params.id %} id="{{ params.id }}"{% endif %}
{% if params.attributes %}{% for attribute, value in (params.attributes.items() if params.attributes is mapping and params.attributes.items else params.attributes) %}{{ attribute }}{% if value %}="{{ value }}"{% endif %}{% endfor %}{% endif %}
>
Expand Down
Loading