Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring Unnecessary Conditionals: Question #3101

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Mar 19, 2024

What is the context of this PR?

#3026... Added the warning param in _macro_options.md.

How to review this PR

Check that params declared in the component are present in _macro_options.md

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit dcced82
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/65f984c94e05840009458abe
😎 Deploy Preview https://deploy-preview-3101--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV self-assigned this Mar 19, 2024
@SriHV SriHV added the Enhancement Change of existing feature label Mar 19, 2024
@SriHV SriHV linked an issue Mar 19, 2024 that may be closed by this pull request
3 tasks
@SriHV SriHV requested a review from a team March 19, 2024 12:28
@SriHV SriHV marked this pull request as ready for review March 19, 2024 12:28
@SriHV SriHV changed the title Changes in Documentation Exploring Unnecessary Conditionals: Question Mar 19, 2024
@SriHV SriHV merged commit 03c736d into main Mar 21, 2024
10 checks passed
@SriHV SriHV deleted the enhancement/3026/unneccessary-conditionals-question branch March 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploring Unnecessary Conditionals: Question
3 participants