Update markdown #3097
Merged
Update markdown #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
approved these changes
Mar 18, 2024
alessioventuriniAND
approved these changes
Mar 18, 2024
balibirchlee
approved these changes
Mar 18, 2024
rmccar
requested changes
Mar 21, 2024
rmccar
approved these changes
Apr 2, 2024
…or-documentation' into enhancement/3023/language-selector-documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3023
Small error in documentation for language selector where in code
languages.abbrTextwas described aslanguage.TextAbbr. Fixed thisIn addition to this change there were some changes to the backstopJS config. Firstly the reverting of
"headless": "old"made sure we used the old chromium renderer with puppeteer as the newer one had differences with fonts and spacing and performance is slower. It also removed the deprecation warning. The second change isnetwork idle: 0which means the internal server will wait till the full page is received. This change was to combat the missing renders of full pages in the CI.How to review this PR
Check documentation for language selector
Checklist
This needs to be completed by the person raising the PR.