Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role to SVG logo in the footer #3095

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Mar 15, 2024

What is the context of this PR?

Fixes https://github.com/ONSdigital/ons-service-manual-website/issues/379

This PR applies the role of image to the ONS logo image(SVG) in the footer.

How to review this PR

Ensure all instances of images in the footer have the 'role' of image and the word 'logo' in their title text.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Accessibility Issues discovered through accessibility testing label Mar 15, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team March 15, 2024 12:20
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 9161ee3
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/65f43d2be7fcda0008a6d46c
😎 Deploy Preview https://deploy-preview-3095--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit e1e4466 into main Mar 18, 2024
11 of 13 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/add-role-of-image-to-svg branch March 18, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants