Fix single inputs not clearing for mutually exclusive fields #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d099cfb to
266a73e
Compare
src/components/mutually-exclusive/mutually-exclusive.date.spec.js
Outdated
Show resolved
Hide resolved
precious-onyenaucheya-ons
approved these changes
Mar 15, 2024
|
Changes look good! |
alessioventuriniAND
approved these changes
Mar 18, 2024
…field-input-clear
rmccar
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3092
When a single input is used with the date or duration components alongside mutually exclusive checking the mutually exclusive option doesn't clear the input. This was a bug with the input not being passed to the mutually exclusive component. This was missed because of missing test coverage so I have added tests for this too.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.