Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pagination docs #3083

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Update pagination docs #3083

merged 3 commits into from
Mar 11, 2024

Conversation

adi-unni
Copy link
Contributor

What is the context of this PR?

Fixes: #3079

The headingLevel param is not used in the pagination macro but is in the macro options. Update docs to reflect the current parameters in use.

How to review this PR

Describe the steps required to test the changes (include screenshots if appropriate).

Check the macro options markdown.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@adi-unni adi-unni added the Documentation Documentation content or feature for the design system website label Mar 11, 2024
@adi-unni adi-unni requested a review from a team March 11, 2024 13:38
@adi-unni adi-unni self-assigned this Mar 11, 2024
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit c80d8e9
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/65ef40f3ada4fa000833a4c9
😎 Deploy Preview https://deploy-preview-3083--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adi-unni adi-unni requested a review from a team March 11, 2024 13:59
@adi-unni adi-unni merged commit 5f1479e into main Mar 11, 2024
9 checks passed
@adi-unni adi-unni deleted the fix/3079/update-pagination-docs branch March 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation content or feature for the design system website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pagination docs
3 participants