-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/3055/add padding between checkbox list and label #3077
Fix/3055/add padding between checkbox list and label #3077
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as Richard's comment. Once you fix that I am happy to approve too :)
Happy to approve code-wise but might need to get Dina's approval too as there are a lot of changes outside of just the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like Adi mentioned this seems to have had some potential unintended changes. Needs to be checked with Dina/Joe. To me the "Select all that apply" looks a bit far away now but see what she says.
What is the context of this PR?
Aligns padding of checkbox label with other text - rather than 'adding' padding, I actually removed the padding css that was specifically reducing the padding of checkbox labels.
The VR tests are passing locally but failing here - I think a github issue not a code issue.
Fixes: #3055
How to review this PR
You can see the difference on the checkboxes pages.
Checklist
This needs to be completed by the person raising the PR.