Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring Unnecessary Conditionals: Mutually-Exclusive #3076

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Mar 7, 2024

What is the context of this PR?

#3025 .... Added new params that were missing in _macro_options.md

How to review this PR

Check that params mentioned in examples are present in readme

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@SriHV SriHV added the Enhancement Change of existing feature label Mar 7, 2024
@SriHV SriHV self-assigned this Mar 7, 2024
@SriHV SriHV linked an issue Mar 7, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 72789b3
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/65ef0ca86e53990008c5d32c
😎 Deploy Preview https://deploy-preview-3076--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV marked this pull request as ready for review March 7, 2024 13:26
@SriHV SriHV requested a review from a team March 7, 2024 13:28
Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autosuggestResults and the fieldset params are missing

Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the way we have the params in other components are that the initial table is set up for params passed in with param.<paramName> then all the other tables like the fieldset one you have done here are for params passed in as an object to another one. Here I think they should all be in the same table. Check https://service-manual.ons.gov.uk/design-system/components/input#example.example-input-text.nunjucks-macro-options to see what I mean

@SriHV SriHV merged commit 23c358f into main Mar 11, 2024
9 checks passed
@SriHV SriHV deleted the enhancement/3025/explore-mutually-exclusive branch March 11, 2024 15:13
@rmccar rmccar added Documentation Documentation content or feature for the design system website and removed Enhancement Change of existing feature labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation content or feature for the design system website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploring Unnecessary Conditionals: Mutually-Exclusive
3 participants