-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploring Unnecessary Conditionals: Mutually-Exclusive #3076
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autosuggestResults
and the fieldset params are missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the way we have the params in other components are that the initial table is set up for params passed in with param.<paramName>
then all the other tables like the fieldset one you have done here are for params passed in as an object to another one. Here I think they should all be in the same table. Check https://service-manual.ons.gov.uk/design-system/components/input#example.example-input-text.nunjucks-macro-options to see what I mean
What is the context of this PR?
#3025 .... Added new params that were missing in _macro_options.md
How to review this PR
Check that params mentioned in examples are present in readme
Checklist
This needs to be completed by the person raising the PR.