Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter padding on autosuggest items to match input #3074

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

balibirchlee
Copy link
Contributor

@balibirchlee balibirchlee commented Mar 6, 2024

What is the context of this PR?

Changed the padding for items in list for auto suggest to match the search item.

Fixes: #3058

How to review this PR

Spin it up and go to the autosuggest component, type something and have a look!

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@balibirchlee balibirchlee added the Bug Something isn't working label Mar 6, 2024
@balibirchlee balibirchlee requested a review from rmccar March 6, 2024 17:44
@balibirchlee balibirchlee self-assigned this Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 879e57f
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/65e8ab880f6f240008493a72
😎 Deploy Preview https://deploy-preview-3074--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar
Copy link
Contributor

rmccar commented Mar 7, 2024

The best way I found to review this was to comment out the handleBlur function in the autosuggest js file. That will stop the options disappearing when you click off it

@alessioventuriniAND alessioventuriniAND merged commit 2a74994 into main Mar 11, 2024
11 checks passed
@alessioventuriniAND alessioventuriniAND deleted the fix/3058/autosuggest-box-resizing branch March 11, 2024 09:44
@rmccar rmccar changed the title alters the padding on autosuggest items to mattch input Alter padding on autosuggest items to match input Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosuggest: the result box is some few pixels larger that the input box
4 participants