Fix headingLevel error in jinja2 environment for section nav component #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessioventuriniAND
approved these changes
Mar 11, 2024
adi-unni
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3073
Using the section navigation component in a jinja environment without supplying the
headingLevelparam is causing an error. This is because of the cast to int. I have fixed this in this PR by making the param an int so that the cast doesn't have to happen.I also noticed that there were a couple of components using
titleSizefor the same thing so I have updated them to make them consistent across the service.BREAKING CHANGE
Services using the
titleSizeparam with the card component will now need to rename that param toheadingLevelin their config. Services using theheadingLevelparam with the feedback and section navigation components will need to supply an int instead of a string now.How to review this PR
Test the card, feedback, summary and section navigation components still work as expected with and without the headingLevel param
Checklist
This needs to be completed by the person raising the PR.