Fix/3035/review ga implementation #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
approved these changes
Mar 5, 2024
rmccar
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
fixes:#3035
I have updated the current implementation of GA tracking with gtag.js. I am currently working on getting the docs updated to reflect this change. With this update if our users want to send limited data manually to GA4 they can do so by adding gtag.js to their service and by setting the data-ga parameter to their components. This also gives them the opportunity of setting up their own JS in case they want to send custom event that are different from the ones we provide.
How to review this PR
It will be easier to show you how to test this as you will need many different environment setup.
Checklist
This needs to be completed by the person raising the PR.