Update highlight CSS for strong tags #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessioventuriniAND
approved these changes
Mar 4, 2024
precious-onyenaucheya-ons
approved these changes
Mar 5, 2024
adi-unni
approved these changes
Mar 5, 2024
rmccar
added a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3031
When the move from using
<em>to<strong>tags for highlighted text was made the css wasn't updated. This PR fixes that and changes the implementation to now just need strong tags used in a header in order for the highlighting to the text to be applied. The option to add theons-highlightclass is still available to add to any other text if highlighting is needed outside of a header. For document list search result highlighting we should use<mark>which has also been updated to match our highlighting style.The service manual documentation will need updating after this change.
Also some formatting has been fixed.
BREAKING CHANGE
Services using
emtags to highlight text in titles will now need to use thestrongtag instead.How to review this PR
Checklist
This needs to be completed by the person raising the PR.