Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description list not structured properly for screen readers #3053

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Description list not structured properly for screen readers #3053

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd7ee42
initial change
precious-onyenaucheya-ons Feb 26, 2024
7530868
update test
precious-onyenaucheya-ons Feb 27, 2024
6d65654
Merge branch 'main' into feature/fix-list-structure-not-properly-repr…
precious-onyenaucheya-ons Feb 27, 2024
83399b2
update test
precious-onyenaucheya-ons Feb 28, 2024
bece1a7
Merge branch 'main' into feature/fix-list-structure-not-properly-repr…
precious-onyenaucheya-ons Feb 28, 2024
908f4b6
update comment
precious-onyenaucheya-ons Feb 28, 2024
a902fc6
update comment
precious-onyenaucheya-ons Feb 28, 2024
b1a488b
Merge branch 'main' into feature/fix-list-structure-not-properly-repr…
precious-onyenaucheya-ons Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 17 additions & 50 deletions src/components/summary/_macro.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,20 +303,23 @@ const EXAMPLE_SUMMARY_MULTIPLE_GROUPS = {
],
};

// Disable specific axe rules to accommodate the testing scenario
const axeRules = {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
};

describe('macro: summary', () => {
describe('mode: general', () => {
it('passes jest-axe checks', async () => {
const $ = cheerio.load(renderComponent('summary', EXAMPLE_SUMMARY_BASIC));
const results = await axe($.html(), {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
});
const results = await axe($.html(), axeRules);

expect(results).toHaveNoViolations();
});
Expand Down Expand Up @@ -529,16 +532,7 @@ describe('macro: summary', () => {
describe('mode: with title', () => {
it('passes jest-axe checks', async () => {
const $ = cheerio.load(renderComponent('summary', EXAMPLE_SUMMARY_WITH_TITLE));
const results = await axe($.html(), {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
});
const results = await axe($.html(), axeRules);

expect(results).toHaveNoViolations();
});
Expand All @@ -558,16 +552,7 @@ describe('macro: summary', () => {
variant: 'hub',
}),
);
const results = await axe($.html(), {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
});
const results = await axe($.html(), axeRules);

expect(results).toHaveNoViolations();
});
Expand Down Expand Up @@ -601,16 +586,7 @@ describe('macro: summary', () => {
it('passes jest-axe checks', async () => {
const $ = cheerio.load(renderComponent('summary', EXAMPLE_SUMMARY_WITH_NO_ROWS));

const results = await axe($.html(), {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
});
const results = await axe($.html(), axeRules);
expect(results).toHaveNoViolations();
});

Expand Down Expand Up @@ -649,16 +625,7 @@ describe('macro: summary', () => {
describe('mode: card', () => {
it('passes jest-axe checks', async () => {
const $ = cheerio.load(renderComponent('summary', { ...EXAMPLE_SUMMARY_BASIC, variant: 'card' }));
const results = await axe($.html(), {
rules: {
dlitem: {
enabled: false,
},
'definition-list': {
enabled: false,
},
},
});
const results = await axe($.html(), axeRules);

expect(results).toHaveNoViolations();
});
Expand Down
Loading