Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #2851

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Update issue templates #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43a301f
update issues templates
rmccar Oct 19, 2023
5357bf0
update snapshot with removal of whitespace
rmccar Oct 19, 2023
af8ce26
add community backlog project
rmccar Oct 19, 2023
a806084
convert checkboxes into dropdowns with multiple answers allowed
rmccar Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions .github/ISSUE_TEMPLATE/bug_report.yaml → .github/ISSUE_TEMPLATE/bug-report.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Bug Report
description: File a bug report
title: "[Bug]: "
labels: ["bug", "triage"]
labels: ["Bug", "Triage"]
projects: ["ONS Design System project", "ONS Design Team community backlog"]
assignees: []
body:
- type: markdown
Expand Down Expand Up @@ -47,49 +48,52 @@ body:
placeholder: For example, 32.2.7
validations:
required: true
- type: checkboxes
- type: dropdown
id: device
attributes:
label: What devices are you seeing the problem on?
options:
- label: Desktop
- label: Mobile
- label: Tablet
- Desktop
- Mobile
- Tablet
multiple: true
- type: input
id: device-details
attributes:
label: Device details
description: Here you can provide further information about the device(s) that are affected by this bug or issue.
validations:
required: false
- type: checkboxes
- type: dropdown
id: operating-system
attributes:
label: What operating systems are you seeing the problem on?
options:
- label: Windows
- label: macOS
- label: Android
- label: iOS
- label: Other
- Windows
- macOS
- Android
- iOS
- Other
multiple: true
- type: input
id: operating-system-details
attributes:
label: Operating system details
description: Here you can provide further information about the operating system(s) that are affected by this bug or issue.
validations:
required: false
- type: checkboxes
- type: dropdown
id: browsers
attributes:
label: What browsers are you seeing the problem on?
options:
- label: Firefox
- label: Chrome
- label: Safari
- label: Microsoft Edge
- label: Microsoft Internet Explorer
- label: Other
- Firefox
- Chrome
- Safari
- Microsoft Edge
- Microsoft Internet Explorer
- Other
multiple: true
- type: input
id: browsers-details
attributes:
Expand Down
5 changes: 3 additions & 2 deletions .github/ISSUE_TEMPLATE/feature_request.yaml → .github/ISSUE_TEMPLATE/feature-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
name: New feature proposal
description: Propose a new component, pattern, foundation or documentation to add to the ONS Design System
title: "[Feature]: "
labels: ["New feature proposal", "triage"]
labels: ["New feature proposal", "Triage"]
projects: ["ONS Design System project", "ONS Design Team community backlog"]
assignees: []
body:
- type: markdown
attributes:
value: |
**Before you fill in this proposal template:**
- If you are suggesting a change to a component, pattern or foundation that is already in the ONS Design System, please comment on its [GitHub discussion instead] (https://github.com/ONSdigital/design-system/discussions). You can get to the discussion using the direct link at the bottom of each page in the Design System.
- If you are suggesting a change to a component, pattern or foundation that is already in the ONS Design System, please comment on its [GitHub discussion instead](https://github.com/ONSdigital/design-system/discussions). You can get to the discussion using the direct link at the bottom of each page in the Design System.
- If you are proposing something new, check the [ONS Design System community backlog](https://github.com/ONSdigital/design-system/projects/1) first. There may already be a proposal for something similar. You can add examples of your own evidence to an existing proposal.
- type: textarea
id: what
Expand Down
8 changes: 4 additions & 4 deletions __snapshots__/layout/_template.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ exports[`base page template matches the full configuration snapshot 1`] = `
<div class="ons-grid__col ons-col-auto ons-u-d-no@xxs@m">
<nav class="ons-header-service-nav ons-header-service-nav--main " aria-label="Services menu">
<ul class="ons-header-service-nav__list">

<li class="ons-header-service-nav__item">


Expand All @@ -805,7 +805,7 @@ exports[`base page template matches the full configuration snapshot 1`] = `
Jacky Turner

</li>

<li class="ons-header-service-nav__item">


Expand Down Expand Up @@ -875,7 +875,7 @@ exports[`base page template matches the full configuration snapshot 1`] = `

<nav class="ons-header-service-nav ons-header-service-nav--mobile ons-u-d-no ons-js-services-mobile-nav" id="service-links" aria-label="Services menu">
<ul class="ons-header-service-nav__list">

<li class="ons-header-service-nav__item ons-header-service-nav__item--mobile">


Expand All @@ -895,7 +895,7 @@ exports[`base page template matches the full configuration snapshot 1`] = `
Jacky Turner

</li>

<li class="ons-header-service-nav__item ons-header-service-nav__item--mobile">


Expand Down
12 changes: 2 additions & 10 deletions src/components/autosuggest/_macro.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,7 @@ describe('macro: autosuggest', () => {
it('renders div with the provided title text', () => {
const $ = cheerio.load(renderComponent('autosuggest', EXAMPLE_AUTOSUGGEST));

expect(
$('.ons-autosuggest__results-title')
.text()
.trim(),
).toBe('Suggestions');
expect($('.ons-autosuggest__results-title').text().trim()).toBe('Suggestions');
});

it('renders list with a generated identifier', () => {
Expand Down Expand Up @@ -298,11 +294,7 @@ describe('macro: autosuggest', () => {
it('renders instructions text', () => {
const $ = cheerio.load(renderComponent('autosuggest', EXAMPLE_AUTOSUGGEST));

expect(
$('.ons-autosuggest__instructions')
.text()
.trim(),
).toBe('Use up and down keys to navigate.');
expect($('.ons-autosuggest__instructions').text().trim()).toBe('Use up and down keys to navigate.');
});
});
});
4 changes: 2 additions & 2 deletions src/components/header/_macro.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
<div class="ons-grid__col ons-col-auto{% if controlVisibility == true %} ons-u-d-no@xxs@{{ breakpoint }}{% endif %}">
<nav class="ons-header-service-nav ons-header-service-nav--main {{ params.serviceLinks.classes }}" aria-label="{{ params.serviceLinks.ariaLabel | default("Service links navigation") }}">
<ul class="ons-header-service-nav__list">
{% for item in params.serviceLinks.itemsList %}
{% for item in params.serviceLinks.itemsList %}
<li class="ons-header-service-nav__item">
{% if item.iconType %}
{{
Expand Down Expand Up @@ -139,7 +139,7 @@
{% if params.serviceLinks %}
<nav class="ons-header-service-nav ons-header-service-nav--mobile ons-u-d-no ons-js-services-mobile-nav" id="{{ params.serviceLinks.id }}" aria-label="{{ params.serviceLinks.ariaLabel | default("Service links navigation") }}">
<ul class="ons-header-service-nav__list">
{% for item in params.serviceLinks.itemsList %}
{% for item in params.serviceLinks.itemsList %}
<li class="ons-header-service-nav__item ons-header-service-nav__item--mobile">
{% if item.iconType %}
{{
Expand Down
Loading