'Document list' component to replace downloads and articles, and use for search results #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruncher
previously approved these changes
Mar 8, 2022
kruncher
previously approved these changes
Mar 10, 2022
rmccar
requested changes
Mar 10, 2022
kruncher
previously approved these changes
Mar 10, 2022
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
…tem into 1797-search-result
rmccar
approved these changes
Mar 11, 2022
|
Pagination layout issue on News pattern |
Yeah I raised a bug for this #2024 |
boxadesign
approved these changes
Mar 11, 2022
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
…for search results (#2011) * added document component first draft * refector * added date * added more metadata options * corrected page template heading levels * added examples of differenet document types * added featured docs * fixed issues with examples * used new document component in news pattern * documentation * more documentation * fixed bug #1664 * replaced download resources with new document component * removed old components replaced by document * removed unnecessary change * removed unused document examples * revert unrelated changes * removed scss imports for removed components * removed old placeholder thumbnail pngs * removed unused imports from guide example * revert removed onsList from guide rtl example * macro options docs * refactored download resources pattern to use document list * fix for border and margin showing when preceded by hidden item * revert test * updated downloadable resources examples [test-visual] * remove bottom border from inline featured doc * changed name of component and fixed featured image size * updated example folder names * adjusted metadata line height * pr suggestion * Update src/components/document-list/_macro.njk Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com> * Update src/components/document-list/_macro.njk Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com> Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains breaking changes
What is the context of this PR?
Created a new single 'document list' component to be used to display similar types of document links/excerpts. Intended for:
Each variant of this component contains:
What are the breaking changes?
Developers using the following patterns and components will need to replace them with the new
onsDocumentList()macro.Removed components
The new 'document list' component replaces the now deprecated components:
Affected patterns
The following patterns are updated to now use the new 'document' component in replace of the deprecated components listed above:
Closes #1797 and fixes #1664
How to review
Check macro, documentation, variants and examples of the components and patterns listed above.