Removed some aria attributes causing accessibility problems (DAC) #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 33 33
Lines 1506 1506
=======================================
Hits 1410 1410
Misses 96 96 Continue to review full report at Codecov.
|
boxadesign
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the DAC report a few items were causing big issues for screen readers, and as such have been removed.
Each landmark region was marked
role="navigation"causing confusion when navigating the content on the page.Removing both
aria-labelandrole="navigation"resulted in a more efficient experience for a screen reader user.