Added DAC suggestions to warning panel for accessibility reasons #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 33 33
Lines 1506 1506
=======================================
Hits 1410 1410
Misses 96 96 Continue to review full report at Codecov.
|
jrbarnes9
reviewed
Jan 25, 2021
…de consistency tweaks
boxadesign
approved these changes
Jan 26, 2021
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Added DAC suggestions to warning panel for accessibility reasons * Added flexibility to override default icon text for accessibility. Code consistency tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning panel has been updated to meet DAC accessibility requirements
Previous style attributes had not conveyed the important information for screen readers. A visual user would have understood the message whereas a screen reader would have read it out like any other paragraph in the site with no emphasis.
The use of strong has been added as well as screen reader only assistive purpose 'Warning' span.
DAC suggested pattern below
This has been applied using our own visually hidden class.