-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more flexibility for related content and combined related links #1314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1314 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 33 33
Lines 1506 1506
=======================================
Hits 1410 1410
Misses 96 96 Continue to review full report at Codecov.
|
Looks good but all examples seem to have the census theme. Maybe good to have a default |
Ok @boxadesign I will get one added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can we remove 'related links' component now? It is possible only the Census website using it. Maybe leave it in as we don't know what other services are using is, but we should at least remove component from documentation, so no one uses it going forward. Perhaps put in release notes that this new macro should replace it? Then remove component macro later?
@jrbarnes9 I did want to remove the related links, but wanted to leave it in just in case it was being used elsewhere. In regards to release notes. Good idea. Both @boxadesign and @rmccar do the releases. |
…/ONSdigital/design-system into 1312-related-content-enhancement
…ng in purpose. Updated macro option as a required entry
…/ONSdigital/design-system into 1312-related-content-enhancement
…#1314) * Added more flexibility for related content. Added some documentation and guidance * Added default examples for related content * Removed related links component * Updated markup to use aside instead of a div container * Removed role attribute in favour of aria-label to provide understanding in purpose. Updated macro option as a required entry
This component should be used in favour of related links.
BREAKING CHANGE:
Removed the 'related links' component, to be replaced by 'Related content'.
Includes multiple row option
Closes #1312