Merge branch 'main' into fix/3178-incorrect-link-in-address-pattern

ONSdigital · May 13, 2024 · a40379c · a40379c
2 parents 55c6057 + 948f29d
commit a40379c
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/src/components/share-page/_macro.njk b/src/components/share-page/_macro.njk
@@ -6,7 +6,6 @@
         <{{ titleTag }} class="ons-u-fs-r--b ons-u-mb-xs">{{ params.title }}</{{ titleTag }}>
     {% endif %}
 
-    {% set list = [] %}
     {% if params.facebook and params.facebook == true %}
         {% set facebook =
             {
@@ -17,8 +16,6 @@
                 "target": '_blank'
             }
          %}
-
-        {% set list = (list.push(facebook), list) %}
     {% endif %}
     {% if params.twitter and params.twitter == true %}
         {% set twitter =
@@ -30,17 +27,13 @@
                 "target": '_blank'
             }
          %}
-
-        {% set list = (list.push(twitter), list) %}
-
     {% endif %}
-
     {{
         onsList({
             "variants": 'inline',
             "iconPosition": 'before',
             "iconSize": params.iconSize | default("xxl"),
-            "itemsList": list
+            "itemsList": [facebook, twitter]
         })
     }}
 {% endmacro %}