Skip to content

Commit

Permalink
VR tests moved to ubuntu (#3368)
Browse files Browse the repository at this point in the history
* testing

* Update visual-regression-tests.yml

* added docker step

* updated localhost

* testing new url

* testing new url

* updated docker command

* tersting

* workflow for vr updated
  • Loading branch information
alessioventuriniAND authored Sep 25, 2024
1 parent 63ca1b4 commit 5415424
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/visual-regression-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ env:

jobs:
run-visual-regression-tests:
runs-on: macos-12
runs-on: ubuntu-latest

steps:
- name: Checkout
Expand All @@ -20,10 +20,8 @@ jobs:
node-version-file: '.nvmrc'
- name: Install dependencies
run: yarn install
- name: Install Docker
run: |
brew install docker
colima start
- name: Set up Docker
uses: docker/setup-buildx-action@v3
- name: Run visual regression tests
id: vr
run: yarn test-visual
Expand Down
2 changes: 1 addition & 1 deletion backstop.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ module.exports = {
},
report: process.env.RUNNING_IN_CI === 'true' ? [] : ['browser'],
dockerCommandTemplate:
'docker run --rm -i --user $(id -u):$(id -g) --mount type=bind,source="{cwd}",target=/src backstopjs/backstopjs:{version} {backstopCommand} {args}',
'docker run --rm -i --user $(id -u):$(id -g) --add-host=host.docker.internal:host-gateway --mount type=bind,source="{cwd}",target=/src backstopjs/backstopjs:{version} {backstopCommand} {args}',
};

0 comments on commit 5415424

Please sign in to comment.