Remove min and max attributes from text type inputs (#3161)

ONSdigital · Apr 29, 2024 · 1ce2300 · 1ce2300
1 parent 1b1849d
commit 1ce2300
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 77 deletions.
diff --git a/src/components/autosuggest/_macro.njk b/src/components/autosuggest/_macro.njk
@@ -62,8 +62,6 @@
             "accessiblePlaceholder": params.input.accessiblePlaceholder,
             "name": params.input.name,
             "autosuggestResults": autosuggestResults,
-            "min": params.input.min,
-            "max": params.input.max,
             "minLength": params.input.minLength,
             "maxLength": params.input.maxLength,
             "prefix": params.input.prefix,

diff --git a/src/components/autosuggest/_macro.spec.js b/src/components/autosuggest/_macro.spec.js
@@ -157,9 +157,7 @@ describe('macro: autosuggest', () => {
           },
           mutuallyExclusive: null,
           accessiblePlaceholder: true,
-          name: 'country-of-birth-test',
-          min: 1,
-          max: 10,
+          name: 'test-params',
           minLength: 1,
           maxLength: 10,
           prefix: {
@@ -210,10 +208,8 @@ describe('macro: autosuggest', () => {
       expect(inputSpy.occurrences[0]).toHaveProperty('error.text', 'An error occurred.');
       expect(inputSpy.occurrences[0]).toHaveProperty('mutuallyExclusive', null);
       expect(inputSpy.occurrences[0]).toHaveProperty('accessiblePlaceholder', true);
-      expect(inputSpy.occurrences[0]).toHaveProperty('name', 'country-of-birth-test');
+      expect(inputSpy.occurrences[0]).toHaveProperty('name', 'test-params');
       expect(typeof inputSpy.occurrences[0].autosuggestResults).toBe('string');
-      expect(inputSpy.occurrences[0]).toHaveProperty('min', 1);
-      expect(inputSpy.occurrences[0]).toHaveProperty('max', 10);
       expect(inputSpy.occurrences[0]).toHaveProperty('minLength', 1);
       expect(inputSpy.occurrences[0]).toHaveProperty('maxLength', 10);
       expect(inputSpy.occurrences[0]).toHaveProperty('prefix.title', 'Great British Pounds');

diff --git a/src/components/date-input/_macro.njk b/src/components/date-input/_macro.njk
@@ -25,8 +25,6 @@
                 "name": params.day.name,
                 "classes": (" ons-input--error" if (params.error and params.day.error) or (params.error and not params.day.error and not params.month.error and not params.year.error) else "") + exclusiveClass | default(""),
                 "width": "2",
-                "min": 1,
-                "max": 31,
                 "maxLength": 2,
                 "attributes": params.day.attributes,
                 "label": {
@@ -46,8 +44,6 @@
                 "name": params.month.name,
                 "classes": (" ons-input--error" if (params.error and params.month.error) or (params.error and not params.day.error and not params.month.error and not params.year.error) else "") + exclusiveClass | default(""),
                 "width": "2",
-                "min": 1,
-                "max": 12,
                 "maxLength": 2,
                 "attributes": params.month.attributes,
                 "label": {
@@ -67,8 +63,6 @@
                 "name": params.year.name,
                 "classes": (" ons-input--error" if (params.error and params.year.error) or (params.error and not params.day.error and not params.month.error and not params.year.error) else "") + exclusiveClass | default(""),
                 "width": "4",
-                "min": 1000,
-                "max": 3000,
                 "maxLength": 4,
                 "attributes": params.year.attributes,
                 "label": {

diff --git a/src/components/date-input/_macro.spec.js b/src/components/date-input/_macro.spec.js
@@ -173,8 +173,6 @@ describe('macro: date input', () => {
         type: 'number',
         name: 'day',
         width: '2',
-        min: 1,
-        max: 31,
         maxLength: 2,
         classes: '',
         error: '',
@@ -201,8 +199,6 @@ describe('macro: date input', () => {
         type: 'number',
         name: 'month',
         width: '2',
-        min: 1,
-        max: 12,
         maxLength: 2,
         classes: '',
         error: '',
@@ -229,8 +225,6 @@ describe('macro: date input', () => {
         type: 'number',
         name: 'year',
         width: '4',
-        min: 1000,
-        max: 3000,
         maxLength: 4,
         classes: '',
         error: '',
@@ -349,8 +343,6 @@ describe('macro: date input', () => {
         type: 'number',
         name: 'year',
         width: '4',
-        min: 1000,
-        max: 3000,
         maxLength: 4,
         classes: '',
         label: {

diff --git a/src/components/input/_macro-options.md b/src/components/input/_macro-options.md
diff --git a/src/components/input/example-input-number.njk b/src/components/input/example-input-number.njk
@@ -1,13 +1,11 @@
 {% from "components/input/_macro.njk" import onsInput %}
+
 {{
     onsInput({
         "id": "number-example-input",
         "type": "number",
         "width": "2",
         "autocomplete": "off",
-        "attributes": {
-            "min": 0
-        },
         "label": {
             "text": "Number of bedrooms"
         }

diff --git a/src/components/input/example-input-numeric-values.njk b/src/components/input/example-input-numeric-values.njk
@@ -5,9 +5,6 @@
         "type": "number",
         "width": "2",
         "autocomplete": "off",
-        "attributes": {
-            "min": 0
-        },
         "label": {
             "text": "Number of bedrooms"
         }

diff --git a/src/components/mutually-exclusive/example-mutually-exclusive-number.njk b/src/components/mutually-exclusive/example-mutually-exclusive-number.njk
@@ -11,9 +11,6 @@
             "dontWrap": true,
             "type": "number",
             "width": "4",
-            "attributes": {
-                "min": 0
-            },
             "label": {
                 "text": "Gross annual income"
             },

diff --git a/src/components/mutually-exclusive/mutually-exclusive.duration.spec.js b/src/components/mutually-exclusive/mutually-exclusive.duration.spec.js
@@ -13,10 +13,6 @@ const EXAMPLE_MUTUALLY_EXCLUSIVE_DURATION_PARAMS = {
       text: 'Years',
       id: 'address-duration-years-suffix',
     },
-    attributes: {
-      min: 0,
-      max: 100,
-    },
   },
   field2: {
     id: 'address-duration-months',
@@ -25,10 +21,6 @@ const EXAMPLE_MUTUALLY_EXCLUSIVE_DURATION_PARAMS = {
       text: 'Months',
       id: 'address-duration-months-suffix',
     },
-    attributes: {
-      min: 0,
-      max: 11,
-    },
   },
   mutuallyExclusive: {
     or: 'Or',
@@ -59,10 +51,6 @@ const EXAMPLE_MUTUALLY_EXCLUSIVE_DURATION_SINGLE_PARAMS = {
       text: 'Years',
       id: 'address-duration-years-suffix',
     },
-    attributes: {
-      min: 0,
-      max: 100,
-    },
   },
   mutuallyExclusive: {
     or: 'Or',

diff --git a/src/components/mutually-exclusive/mutually-exclusive.number.spec.js b/src/components/mutually-exclusive/mutually-exclusive.number.spec.js
@@ -7,9 +7,6 @@ const EXAMPLE_MUTUALLY_EXCLUSIVE_NUMBER_INPUT_PARAMS = {
   type: 'number',
   legend: 'What is your annual income before tax in 2018/19?',
   width: '5',
-  attributes: {
-    min: 0,
-  },
   label: {
     text: 'Gross annual income',
   },