-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JA4 for TLS and QUIC -- v9 #10579
JA4 for TLS and QUIC -- v9 #10579
Conversation
This gives app layer code a chance to access feature information.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10579 +/- ##
==========================================
- Coverage 82.67% 82.62% -0.05%
==========================================
Files 922 927 +5
Lines 246969 247803 +834
==========================================
+ Hits 204179 204753 +574
- Misses 42790 43050 +260
Flags with carried forward coverage won't be shown. Click here to find out more. |
Added back the ticket reference in the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work Sascha :-)
- CI : needs a rebase to fix the small conflict
- Code : doing now
- Commits segmentation : nice
- Commit messages : ok for me
- Git ID set : looks fine for me
- CLA : you already contributed :-)
- Doc update : Ok
- Redmine ticket : ok
- Rustfmt : ok for ja4.rs
- Tests : Left remarks there
- Dependencies added: none
Compiling with |
True, I just addressed this and also double-checked that for JA3. |
New PR: #10725 |
Previous PR: #10341
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379
Changes to previous PR:
ja4.ciphersuites.len()
instead of separate counter.#define
carried over from older code.JA4_HEX_LEN
into separate header to be used in detect and output code.