Skip to content

Commit

Permalink
chore: run workflow on published releases (#149)
Browse files Browse the repository at this point in the history
Github will not sent events for draft releases.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

So this workflow won't work, we the release must be published for the workflow to kick in.

Release-As: 1.5.3
  • Loading branch information
OGKevin authored Jul 9, 2023
1 parent 05052f0 commit 3706570
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Build plugin
on:
release:
types:
- "unpublished"
- "published"

env:
PLUGIN_NAME: kobo-highlights-import
Expand Down Expand Up @@ -58,7 +58,3 @@ jobs:
asset_path: ./manifest.json
asset_name: manifest.json
asset_content_type: application/json
- uses: eregon/publish-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
2 changes: 1 addition & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"release-type": "node",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": true,
"draft": false,
"prerelease": false,
"extra-files": [
{
Expand Down

0 comments on commit 3706570

Please sign in to comment.