paypal error after redirect to site.

[papppeter]

Twig token error after payment.

paypal was in sandbox mode. in paypal i could finalize the payment. after redirect back to cart i got this error.

payment was successfully registered.

[papppeter]

I think the problem here is: DefaultMoney class. I am not sure about it but, if i am removing the render part than it starts working. so my thinking is: we are using inside mail generation the same twig instance which breaks template generation. (twig thinks the render is already started.)

i hope you can look into this. or at least you could use somehow an another twig instance. I see the boot that you create mall.twig.environment but i think this still crashes with the main twig render.

what do you think? what should i provide for recreating the problem?

[papppeter]

one more info, if i remove all this type of methods {{ item.totalPostTaxes() | raw }} from mall.order.table than it starts working.

[tobias-kuendig]

Yes, the problem here is the currency rendering. The custom twig environment should solve this issue. It's a problem with October that needs to be sorted. Papp Péter <notifications@github.com> schrieb am Do., 30. Mai 2019, 17:57:

…

one more info, if i remove all this type of methods {{ item.totalPostTaxes() | raw }} from mall.order.table than it starts working. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#258?email_source=notifications&email_token=ACBTTXMSZLHUYDLLPSVRNN3PX72PZA5CNFSM4HREWHPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSXETQ#issuecomment-497381966>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBTTXLJH6SN6XOQXD65PM3PX72PZANCNFSM4HREWHPA> .

[papppeter]

Hi,

do you know the issue where octobercms team is working on this?

[papppeter]

ok i did found it. octobercms/october#3341

but i am on the latest october version, or i hope at least. do you have any suggestion what should i check?

"name": "october/system",
"version": "v1.0.454",

[papppeter]

Hi Tobias,

i found out a solution:

protected function render($contents, array $vars)
{
    return (new Twig)->parse($contents, $vars);
}

why are you using this differently? i saw in your code "paymentMethod.renderInstructions" i think that method is just working as expected.

what do you think? in this case you don't need twig booting process at all.

i did tested with paypal, and it was working for me, total table was displayed correctly.

[Eoler]

Also got Call to a member function getCurrent() on null after successfully handling redirection from a custom paymentProvider, it indicates that it is in the middle of handling mailer.beforeAddContent event.

Using standard Twig in boot process makes Unknown "partial" tag in "__string_template exception reappear in other places. Maybe quickfix is not to use Mail queue?

[papppeter]

hi,

@Eoler where does it reappear? for me it works as expected... but maybe i miss something

[Eoler]

Your version of rendering DefaultMoney in Twig throws exception in new order checkout for offline payment providers.

[papppeter]

i see...

can you suggest how i could create a test for this? it is hard to do it over and over.

another question, is it working for you at all? should i try a fresh install?

[papppeter]

Hi,

i have another question, what happen is we are using Money class only one way. It should work as a filter in twig, and we should not give back formatted trough pricePostTaxes() would it maybe solve this issue? Or we should not use it as filter...

unfortuantely i don't see the difference between default money and paymentmethod twig usage.

[Eoler]

Your solution works and solves exception on postback from remote payment provider, but it creates another one in offline payment provider (that probably IS a reason why Tobias implemented it differently).

My current workaround is setting up async queue (to be run from scheduler) and changing DefaultMoney method to:

    protected function render($contents, array $vars)
    {
        if (\App::runningInConsole()) {
            return (new \October\Rain\Parse\Twig)->parse($contents, $vars);
        }
        else {
            $template = $this->twig->createTemplate($contents);
            return $template->render($vars);
        }
    }

[papppeter]

hi,

thanks for your code part! how do i set up async queue, do you have the document link for it? so than all the mails will go over queue?

[Eoler]

It depends on your server: https://octobercms.com/docs/services/queues#running-the-queue-worker
probably the easiest way is to set it up as database and run it in your plugin's scheduler, rough example:

    public function registerSchedule($schedule)
    {
        $schedule->command('queue:work')->everyMinute()->withoutOverlapping();
    }

[tobias-kuendig]

This is a nasty issue that I have already spent many hours on.

The solution provided by @papppeter was my initial solution that introduced the Unknown "partial" tag exception, hence I went on and registered a separate twig environment.

The problem should not appear if you are using a separate queue worker since twig is only loaded once. When the sync queue worker is used, Twig is loaded once by the CMS part of October and then the custom twig environment for Mall is not loaded completely because of how Twig caches things ‒ this leads to the getCurrent() on null error.

I'll have to further look into this... 🙄

[papppeter]

could you build up some testing env? where it would be easier to recreate this problem? for me the hardest part was that i needed to go trough all the payment process to land on this page...

maybe the another sollution could be not using twig for money formatting. i don't think i would miss it if i could have same basic formatting. (currency prefix, postfix, how number function should called.)

[tobias-kuendig]

could you build up some testing env? where it would be easier to recreate this problem? for me the hardest part was that i needed to go trough all the payment process to land on this page...

Yeah, that's what make this a time consuming problem for me as well. I tried to dig into the call stack and isolate the issue but the whole Twig/October boot cycle is a huge rabbit hole and not that easy to follow.

maybe the another sollution could be not using twig for money formatting. i don't think i would miss it if i could have same basic formatting. (currency prefix, postfix, how number function should called.)

I'd rather fix the issue upstream than re-inventing the wheel. Having the full feature set of Twig at hand provides many benefits.

[Eoler]

Rabbit hole indeed, my workaround with async queued mails dropped me into one (templates are sent with EN translations): rainlab/translate-plugin#285

[papppeter]

HI,

i just tried to long, now i removed that feature from my fork. Please write here if you could create a test area, or if you could fix the issue.

thanks!

my solution is:

protected function render($contents, array $vars)
{
        return number_format($vars['price'],$vars['currency']->decimals,  ',', ' ').' '.$vars['currency']->symbol;
}

[Dreanad]

Hey there, same issue for me,
what do you recommand to do for ?

[tobias-kuendig]

For the time being, you'd have to replace these lines and not rely on the twig environment:

https://github.com/OFFLINE-GmbH/oc-mall-plugin/blob/develop/classes/utils/DefaultMoney.php#L44

See papppeter's comment from above. If you don't need different formatting for different currencies this is very easy to implement.

[Dreanad]

Thank you for your response,
how can i do this properly ? I dont want to modify the plugin directly

[tobias-kuendig]

1. Create your own plugin
2. Create a class that extends Mall's DefaultMoney class
3. Make changes to the render method
4. In your own Plugin's boot method, register your own Money implementation like so:

https://github.com/OFFLINE-GmbH/oc-mall-plugin/blob/develop/classes/registration/BootServiceContainer.php#L39

[Zmove]

Can someone who has developed this custom module share it with the community?

[tobias-kuendig]

I might be able to tackle this issue in the next few days. It's possible that we need to find an alternative to rendering the currency format using the Twig::parse method as it somehow runs in an "incomplete twig environment" when it is used in mail partials.

[tobias-kuendig]

I did open a issue with a proof of this problem: https://github.com/octobercms/october/issues/4874

Let's see if someone from the community is able to help.

[marcomessa]

Hello guys. I confirm the issue, and I confirm that the workaround explained up here is working flawlessly. Thank you for sharing, and thank you for your work!

[zlobec]

Hey,
I get this error only when sending email to client, but not to the admin. The email to admin has correctly formatted |money format. Is this the same issue?

[tobias-kuendig]

So we've got a great workaround from @jacobdekeizer over in https://github.com/octobercms/support/issues/35

See c5075fd, let me know if the problem persists!