Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-2137: downgrade dependencies to pre-poetry versions #177

Merged
merged 3 commits into from
Jul 15, 2024
Merged

CC-2137: downgrade dependencies to pre-poetry versions #177

merged 3 commits into from
Jul 15, 2024

Conversation

jonholdsworth
Copy link

Jira Ticket

CC-2137 NZSL: move signbank to Poetry

Changes

  • This restores the exact package versions from the original requirements.txt

@jonholdsworth jonholdsworth self-assigned this Jul 15, 2024
@jonholdsworth jonholdsworth requested review from G-Rath and nzlaura July 15, 2024 00:05
@jonholdsworth jonholdsworth marked this pull request as draft July 15, 2024 00:07
@jonholdsworth
Copy link
Author

jonholdsworth commented Jul 15, 2024 •
edited
Loading

The pinned Certifi version for NZSL Signbank is failing OSV.
I can pin it at the GHSA approved version in pyproject.toml
Or would you prefer I do it separately in a Dependabot PR? That would still require unpinning it.

Update: We are not bothering for now. Will not prevent CI deployment.

G-Rath
G-Rath reviewed Jul 15, 2024
View reviewed changes
@jonholdsworth jonholdsworth marked this pull request as ready for review July 15, 2024 01:06
@G-Rath G-Rath changed the title CC-2137 NZSL Poetry: Pinning to exact original dependencies CC-2137: downgrade dependencies to pre-poetry versions Jul 15, 2024
G-Rath
G-Rath approved these changes Jul 15, 2024
View reviewed changes
Copy link

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash when merging

@jonholdsworth jonholdsworth merged commit e454b32 into master Jul 15, 2024
4 of 5 checks passed
@jonholdsworth jonholdsworth deleted the CC-2137-nzsl-signbank-poetry-pinning-dependencies branch July 15, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

@nzlaura nzlaura Awaiting requested review from nzlaura

Assignees

@jonholdsworth jonholdsworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonholdsworth @G-Rath