Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-2137: use name instead of path #174

Merged
merged 9 commits into from
Jul 8, 2024
Merged

CC-2137: use name instead of path #174

merged 9 commits into from
Jul 8, 2024

Conversation

jonholdsworth
Copy link

@jonholdsworth jonholdsworth commented Jul 4, 2024 •
edited
Loading

Micky Vale was still getting errors on UAT when she tried to create a new Gloss.
This should hopefully fix this.

JIRA Ticket

CC-2137 NZSL: move signbank to Poetry

Changes

  • GlossVideo method rename_video() uses name instead of path from storage, see Notes below

Notes

@jonholdsworth jonholdsworth self-assigned this Jul 4, 2024
@jonholdsworth jonholdsworth changed the title Versions pinned. path -> name NZSL poetry conversion continued Jul 4, 2024
@jonholdsworth
Revert "urllib3 dependency removed"
8d75a46 
Will put into its own PR

This reverts commit 46e27b5.
@jonholdsworth
Revert "Versions pinned. path -> name"
48fa85b 
Splitting into separate PRs

This reverts commit 1d0ccb4.
@jonholdsworth jonholdsworth changed the title NZSL poetry conversion continued NZSL poetry conversion - fix GlossVideo rename_vide() Jul 4, 2024
@jonholdsworth jonholdsworth changed the title NZSL poetry conversion - fix GlossVideo rename_vide() NZSL poetry conversion - fix GlossVideo rename_video() Jul 4, 2024
@jonholdsworth
Copy link
Author

jonholdsworth commented Jul 4, 2024 •
edited
Loading

This errors sometimes when trying to push a new Gloss to S3, after a long pause.
Internal Server Error.
I strongly suspect it is a gunicorn issue as I have seen this on localhost:
Worker (no URI read) issue benoitc/gunicorn#3207

Added a PR just in case: #175

@G-Rath G-Rath changed the title NZSL poetry conversion - fix GlossVideo rename_video() CC-2137: use name instead of path Jul 8, 2024
G-Rath
G-Rath approved these changes Jul 8, 2024
View reviewed changes
Copy link

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash when merging

@jonholdsworth jonholdsworth merged commit e889a6b into master Jul 8, 2024
5 checks passed
@jonholdsworth jonholdsworth deleted the nzsl-poetry-conversion-continued branch July 8, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

@jadedarko jadedarko Awaiting requested review from jadedarko

@nzlaura nzlaura Awaiting requested review from nzlaura

Assignees

@jonholdsworth jonholdsworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonholdsworth @G-Rath