fix: 6am status - summer time change & group_interval #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Summertime change was calculated compared to Berlin, not UTC. - group_interval cannot be zero - https://github.com/prometheus/alertmanager/blob/14cbe6301c732658d6fe877ec55ad5b738abcf06/config/config.go\#L837 Signed-off-by: /Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
naved001
approved these changes
Apr 5, 2024
DanNiESh
approved these changes
Apr 5, 2024
schwesig
added a commit
to schwesig/OCP-on-NERC_nerc-ocp-config
that referenced
this pull request
Apr 5, 2024
- Summertime change was calculated compared to Berlin, not UTC. - group_interval cannot be zero - https://github.com/prometheus/alertmanager/blob/14cbe6301c732658d6fe877ec55ad5b738abcf06/config/config.go\#L837 Signed-off-by: /Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
computate
pushed a commit
to computate/nerc-ocp-config
that referenced
this pull request
May 29, 2024
- Summertime change was calculated compared to Berlin, not UTC. - group_interval cannot be zero - https://github.com/prometheus/alertmanager/blob/14cbe6301c732658d6fe877ec55ad5b738abcf06/config/config.go\#L837 Signed-off-by: /Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: 6am status - summer time & group_interval
Some ideas how to solve this regularly