[14.0][IMP] shopfloor_base: Propagate the shopfloor.app to actions #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
reviewed
Jan 28, 2025
There was a problem hiding this comment.
@mt-software-de sorry, this fell completely off my radar :)
Comment on lines
34
to
35
| if component_instance.collection._name == "shopfloor.app": | ||
| kwargs["app"] = component_instance.collection |
There was a problem hiding this comment.
I would add an explicit arg app=None and then
Suggested change
| if component_instance.collection._name == "shopfloor.app": | |
| kwargs["app"] = component_instance.collection | |
| if not app and component_instance.collection._name == "shopfloor.app": | |
| app = component_instance.collection | |
| kwargs["app"] = app |
Then you can pass the app also from the actions class.
And we should probably add it to _propagate_kwargs.
You could also add work_context.app in the __init___ of the base service class.
There was a problem hiding this comment.
I changed it.
ad837d9 to
8895807
Compare
simahawk
approved these changes
Feb 6, 2025
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6120b8f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is no property on the actions which represents the app.
Since i'm extending right now the scan everything screens, i need to know the warehouse.
Because by scanning a product i want to show the quants. But not all quants only the configured ones on the app.
The warehouse would then be reachable by
self.work.app.profile_ids.menu_ids.picking_type_ids.warehouse_id@simahawk could you maybe give some more information about this?
Why was this f6f54b0 necessary?
Would i be a problem to set the actions_collection like this
actions_collection = collection or component_instance.collectioncc @jbaudoux