Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] Add stock_move_source_relocate #28

Merged
merged 2 commits into from
Jul 6, 2020
Merged

[13.0] Add stock_move_source_relocate #28

merged 2 commits into from
Jul 6, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented May 20, 2020

Add relocation rules for moves.

Some use cases:

  • Handle all the replenishments at the same place
  • Trigger minimum stock rules or DDMRP buffers in one location

Behavior:

  • When we try to assign a stock move and the move is not available, a
    rule matching the source location (sub-locations included), the picking
    type and an optional domain is searched

  • If a relocation is found, the move source location is updated with
    the new one

  • If the move was partially available, it is split in 2 parts:

  • one available part which keeps its source location

  • one confirmed part which is updated with the new source location

guewen added a commit to guewen/stock-logistics-warehouse that referenced this pull request May 20, 2020
@guewen
Remove fallback location
b17976f 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
guewen added a commit to guewen/stock-logistics-warehouse that referenced this pull request May 20, 2020
@guewen
Remove fallback location
55bbc44 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
@guewen
Add stock_move_source_relocate
db4bd2e 
Add relocation rules for moves.

Some use cases:

* Handle all the replenishments at the same place
* Trigger minimum stock rules or DDMRP buffers in one location

Behavior:

* When we try to assign a stock move and the move is not available, a
  rule matching the source location (sub-locations included), the picking
  type and an optional domain is searched
* If a relocation is found, the move source location is updated with
  the new one
* If the move was partially available, it is split in 2 parts:

 * one available part which keeps its source location
 * one confirmed part which is updated with the new source location
@guewen guewen force-pushed the 13.0-add-stock_move_rechannel branch from f9e810e to 504fddc Compare May 27, 2020 05:51
@jgrandguillaume jgrandguillaume mentioned this pull request May 28, 2020
Closed
62 tasks
jgrandguillaume
jgrandguillaume approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@guewen guewen force-pushed the 13.0-add-stock_move_rechannel branch from 504fddc to 2b95709 Compare July 3, 2020 09:50
@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-28-by-jgrandguillaume-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 6, 2020
@OCA-git-bot
Merge PR #28 into 13.0
cd9379e 
Signed-off-by jgrandguillaume
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-28-by-jgrandguillaume-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 6, 2020
@OCA-git-bot
Merge PR #28 into 13.0
54ba797 
Signed-off-by jgrandguillaume
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-28-by-jgrandguillaume-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8eb976b into OCA:13.0 Jul 6, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7b1c127. Thanks a lot for contributing to OCA. ❤️

AdriaGForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jul 6, 2020
@guewen @AdriaGForgeFlow
Remove fallback location
5e29b41 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
AdriaGForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Jul 20, 2020
@guewen @AdriaGForgeFlow
Remove fallback location
3d975b6 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
sebalix pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Aug 11, 2021
@guewen @sebalix
Remove fallback location
77d2c7f 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
@guewen
Remove fallback location
4ff86c7 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
Ricardoalso pushed a commit to Ricardoalso/stock-logistics-warehouse that referenced this pull request Jun 12, 2023
@guewen @Ricardoalso
Remove fallback location
55c3302 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
rousseldenis pushed a commit to acsone/stock-logistics-warehouse that referenced this pull request Jul 14, 2023
@guewen @rousseldenis
Remove fallback location
5060ba8 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
ibraimFer pushed a commit to Jarsa-dev/stock-logistics-warehouse that referenced this pull request Nov 29, 2024
@guewen @FernizaM22
Remove fallback location
ece0183 
It could not work properly here as we need the "fallback" to apply
even if there is no quantity at all in the stock. As we hook the
reservation rules in StockMove._update_reserved_quantity(), and
this method is called only if we have at least 1 product in qty,
the fallback was not applied with zero qty.

A new module will handle this concept: OCA/wms#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guewen @jgrandguillaume @OCA-git-bot