Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_storage_category_capacity_name #1655

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[16.0][ADD] stock_storage_category_capacity_name #1655

merged 1 commit into from
Apr 12, 2023

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Mar 15, 2023 •
edited
Loading

As in core, Odoo does not implement record name, I've added this.

I did a PR on Odoo too : odoo/odoo#115275

@rousseldenis rousseldenis added this to the 16.0 milestone Mar 15, 2023
@rousseldenis rousseldenis force-pushed the 16.0-add-stock-storage-capacity-name-dro branch from 48ea9b6 to 8e3c876 Compare March 15, 2023 15:21
@rousseldenis rousseldenis mentioned this pull request Mar 15, 2023
Merged
10 tasks
lmignon
lmignon approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review + functional test via OCA/wms#470)

@rousseldenis
Copy link
Contributor Author

@jbaudoux

jbaudoux
jbaudoux approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1655-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 11, 2023
@OCA-git-bot
Merge PR #1655 into 16.0
2befbc0 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1655-by-jbaudoux-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1655-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bc79645 into OCA:16.0 Apr 12, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b0dce1e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rousseldenis @jbaudoux @OCA-git-bot @lmignon