[18.0][MIG] stock_dock: Migration to 18.0

[Kimkhoi3010]

I found only 1 commit to port but it was ignored, I added it to blacklist:

• [16.0][FW] stock_dock: port from 14.0 #161

During the migration of the stock_dock module, I identified two issues in the tms module that needed to be addressed. To resolve these issues, I created two separate commits:

• Commit 1: The kanban-box in the tms module was deprecated in Odoo. This commit replaces the kanban-box definition with the recommended card template to address the warning.
• Commit 2: The group_tms_uom field in the tms module had the same label as group_uom from the product module ("Units of Measure"), causing a conflict. This commit updates the label of group_tms_uom to ensure uniqueness.

[rousseldenis]

/ocabot migration stock_dock

[rousseldenis]

@Kimkhoi3010 Thanks for this. Could you remove all changes related to other modules?

You should respect flow for migration:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

tms changes should go in another PR.

[Kimkhoi3010]

@Kimkhoi3010 Thanks for this. Could you remove all changes related to other modules?

You should respect flow for migration:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

tms changes should go in another PR.

Hi @rousseldenis
I updated by your comment, I have created a PR to fix the issues in tms module: #164

[rousseldenis]

indeed, adding at least some test cases is better. But strangely, right now, no checklog_odoo.cfg still test builds are passed :)

Because tms module has been merged

[Kimkhoi3010]

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

@Kimkhoi3010 @bizzappdev That's because on void tests repository main branch, no tests are run. And no tests are declared in this one.

Even if adding that line to configuration solves errors, I always recommend to add a basic test.

@Kimkhoi3010 Here, you can add a test that checks the default warehouse.

H

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

@Kimkhoi3010 @bizzappdev That's because on void tests repository main branch, no tests are run. And no tests are declared in this one.

Even if adding that line to configuration solves errors, I always recommend to add a basic test.

@Kimkhoi3010 Here, you can add a test that checks the default warehouse.

Hi @rousseldenis, @bizzappdev
I have updated according to your comment, I have added a basic test

[bizzappdev]

Code and Functional Testing LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[simahawk]

@Kimkhoi3010 pls rewrite the last commit as [imp] stock_dock: add tests

[Kimkhoi3010]

@Kimkhoi3010 pls rewrite the last commit as [imp] stock_dock: add tests

Hi @simahawk,
I updated this PR by your comment. Thanks for your time.

[simahawk]

@Kimkhoi3010 pls rewrite the last commit as [imp] stock_dock: add tests

Hi @simahawk, I updated this PR by your comment. Thanks for your time.

I still don't see the module name, there's a not so useful - instead 😉

[Kimkhoi3010]

@Kimkhoi3010 pls rewrite the last commit as [imp] stock_dock: add tests

Hi @simahawk, I updated this PR by your comment. Thanks for your time.

I still don't see the module name, there's a not so useful - instead 😉

Thanks for your time.

[simahawk]

/ocabot merge nobumo

[OCA-git-bot]

Hi @simahawk. Your command failed:

Invalid options for command merge: nobumo.

Ocabot commands

• ocabot merge major|minor|patch|nobump
• ocabot rebase
• ocabot migration {MODULE_NAME}

More information

• ocabot documentation
• OCA guidelines, specially the "Version Numbers" section.

[simahawk]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-160-by-simahawk-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 6bb49bf. Thanks a lot for contributing to OCA. ❤️