-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG]pos_margin #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@legalsylvain I think this one can be merged. THX! |
Can you please integrate the latest changes recently merged in 12.0? |
73d25a0
to
f9dca2b
Compare
Thanks for the reaction @manuelregidor In fact we want to cherry-pick the missing commits instead, in order to respect authors and to keep the proper commit history. In this case, I believe these 3 commits are missing: |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-11.0/pos-11.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_margin/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
Currently translated at 100.0% (8 of 8 strings) Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/pt/
…logic as OCA/margin-analysis/account_invoice_margin module ; [ADD] margin and margin percent on tree pos order view ; [UPD] Description and translation
…g same logic as OCA/margin-analysis/account_invoice_margin module ; [ADD] margin and margin percent on tree pos order view ; [UPD] Description and translation
Co-Authored-By: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>
Currently translated at 75.0% (6 of 8 strings) Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
Currently translated at 100.0% (10 of 10 strings) Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
f9dca2b
to
0030839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is complaining too, because of pre-commit.
Can you check? I believe it's ready to merge as soon as it's green
e518fc5
to
ba4fb01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runbot's still complaining, there are more lines with dp
😅
ba4fb01
to
8edeac7
Compare
@ivantodorovich Done! Thank you! |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
This PR has the |
Congratulations, your PR was merged at c7e51ed. Thanks a lot for contributing to OCA. ❤️ |
Standard migration
Supersedes #399