Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG]pos_margin #669

Merged
merged 24 commits into from
Jul 23, 2021
Merged

Conversation

manuelregidor
Copy link
Contributor

Standard migration
Supersedes #399

Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link

@legalsylvain I think this one can be merged. THX!

@ivantodorovich
Copy link
Contributor

Can you please integrate the latest changes recently merged in 12.0?

@manuelregidor manuelregidor force-pushed the 13.0-mig-pos_margin branch 2 times, most recently from 73d25a0 to f9dca2b Compare June 29, 2021 07:33
@ivantodorovich
Copy link
Contributor

Thanks for the reaction @manuelregidor
I see that you included the latests changes I mentioned in your Migration to 13.0 commit.

In fact we want to cherry-pick the missing commits instead, in order to respect authors and to keep the proper commit history.

In this case, I believe these 3 commits are missing:

legalsylvain and others added 22 commits July 16, 2021 11:30
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-11.0/pos-11.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_margin/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
Currently translated at 100.0% (8 of 8 strings)

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/pt/
…logic as OCA/margin-analysis/account_invoice_margin module ; [ADD] margin and margin percent on tree pos order view ; [UPD] Description and translation
…g same logic as OCA/margin-analysis/account_invoice_margin module ; [ADD] margin and margin percent on tree pos order view ; [UPD] Description and translation
Co-Authored-By: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>
Currently translated at 75.0% (6 of 8 strings)

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
Currently translated at 100.0% (10 of 10 strings)

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin/
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is complaining too, because of pre-commit.
Can you check? I believe it's ready to merge as soon as it's green

pos_margin/models/pos_order.py Outdated Show resolved Hide resolved
@manuelregidor manuelregidor force-pushed the 13.0-mig-pos_margin branch 3 times, most recently from e518fc5 to ba4fb01 Compare July 23, 2021 06:44
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot's still complaining, there are more lines with dp 😅

pos_margin/models/pos_order_line.py Outdated Show resolved Hide resolved
pos_margin/models/pos_order_line.py Outdated Show resolved Hide resolved
pos_margin/models/pos_order_line.py Outdated Show resolved Hide resolved
pos_margin/models/pos_order_line.py Outdated Show resolved Hide resolved
@manuelregidor
Copy link
Contributor Author

@ivantodorovich Done! Thank you!

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-669-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 8b53b74 into OCA:13.0 Jul 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c7e51ed. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 13.0-mig-pos_margin branch July 23, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.