[13.0] [mig] pos_loyalty #623
Conversation
5706a17 to
16e1c1f
Compare
|
Pre-commit fails due to errors in tests. |
|
It would be great if we get the reviews here |
| @@ -11,10 +11,11 @@ | |||
| type="action" | |||
| name="%(point_of_sale.action_pos_pos_form)d" | |||
| context="{'search_default_partner_id': active_id,'default_partner_id': active_id}" | |||
| attrs="{'invisible': ['|', ('customer', '=', False), ('pos_order_count', '=', 0)]}" | |||
| attrs="{'invisible': ['|', ('customer_rank', '=', False), ('pos_order_count', '=', 0)]}" | |||
There was a problem hiding this comment.
@dsolanki-initos customer_rank is a Float
16e1c1f to
31d4619
Compare
|
It seems pre-commit is still failing here |
|
Yes but it is due to test case |
pos_loyalty/static/src/js/tests.js
Outdated
| // Copyright 2004-2018 Odoo SA | ||
| // Copyright 2018 Lambda IS DOOEL <https://www.lambda-is.com> | ||
| // License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
There was a problem hiding this comment.
| /* eslint-disable no-empty-function init-declarations */ | |
To make pre-commit happy:
/home/travis/build/OCA/pos/pos_loyalty/static/src/js/tests.js
33:33 error Unexpected empty method 'run' no-empty-function
60:33 error Unexpected empty method 'run' no-empty-function
70:33 error Unexpected empty method 'run' no-empty-function
76:13 error Variable 'i' should be initialized on declaration init-declarations
78:13 error Variable 'current_char' should be initialized on declaration init-declarations
103:33 error Unexpected empty method 'run' no-empty-function
130:33 error Unexpected empty method 'run' no-empty-function
136:33 error Unexpected empty method 'run' no-empty-function
149:29 error Unexpected empty method 'run' no-empty-function
166:29 error Unexpected empty method 'run' no-empty-function
171:29 error Unexpected empty method 'run' no-empty-function
190:29 error Unexpected empty method 'run' no-empty-function
202:29 error Unexpected empty method 'run' no-empty-function
31d4619 to
d3e9daa
Compare
|
Test are failing and this time is not because of pre-commit, can you check it out? |
f35aa5d to
5c9dd08
Compare
I have added changes as per suggestion but Travis is not happy because of https://app.travis-ci.com/github/OCA/pos/jobs/537261353#L1196. |
That means the module's test tours are failing. It's much easier to debug this locally than on travis, so I recommend you try to run the module tests locally and debug it :) |
21abcca to
e1a8262
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
* [ADD] pos_loyalty: loyalty programs for POS * [FIX] Limit to one discount reward per order * [FIX] Remove unused variables and returns * [IMP] Refactoring rules loading
…_ui when pos_loyalty is installed
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
e1a8262 to
8030c4c
Compare
8030c4c to
5ee402c
Compare
|
@ivantodorovich @chienandalu Could you please review? |
|
@rafaelbn Can you please review this PR? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Maintainers team, Could you please reopen this PR? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.