Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] partner_manual_rank: Migration to 18.0 #1897

Open
wants to merge 41 commits into
base: 18.0
Choose a base branch
from

Conversation

achulii
Copy link

@achulii achulii commented Nov 25, 2024

No description provided.

MiquelRForgeFlow and others added 30 commits November 25, 2024 18:01
Currently translated at 100.0% (6 of 6 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_manual_rank/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_manual_rank/pt/
Currently translated at 100.0% (6 of 6 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_manual_rank/es/
Fields are not stored anymore to avoid computed fields getting outdated and concurrency issues.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-15.0/partner-contact-15.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_manual_rank/
Currently translated at 100.0% (6 of 6 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_manual_rank/fr/
Currently translated at 75.0% (3 of 4 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_manual_rank/it/
…arch_mode` context

Use context set by Odoo in most of their views to pre-fill supplier/customer fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_manual_rank
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_manual_rank/
The base filters added by Odoo create confusion with the ones added in
the module.
@achulii achulii mentioned this pull request Nov 25, 2024
47 tasks
Copy link

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

Comment on lines +45 to +46
<field name="is_customer" invisible="1" />
<field name="is_supplier" invisible="1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the invisible="1" attributes still required here ? Taking into account odoo/odoo#137031

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.