Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] crm_partner_company_group: Migration to 18.0 #1873

Merged
merged 14 commits into from
Dec 3, 2024
Merged

[18.0][MIG] crm_partner_company_group: Migration to 18.0 #1873

merged 14 commits into from
Dec 3, 2024

Conversation

nguyenminhchien
Copy link

@nguyenminhchien nguyenminhchien commented Oct 16, 2024 •
edited
Loading

@nguyenminhchien nguyenminhchien marked this pull request as ready for review October 16, 2024 08:23
This was referenced Oct 16, 2024
Merged
Open
yankinmax and others added 13 commits October 28, 2024 09:24
@yankinmax @nguyenminhchien
[ADD] crm_partner_company_group
a7acc41
@gurneyalex @grindtildeath @nguyenminhchien
Update crm_partner_company_group/hooks.py
8c87f17 
Co-authored-by: Akim Juillerat <akim.juillerat@camptocamp.com>
@gurneyalex @grindtildeath @nguyenminhchien
Update crm_partner_company_group/__manifest__.py
9abaa90 
Co-authored-by: Akim Juillerat <akim.juillerat@camptocamp.com>
@Highcooley @nguyenminhchien
[MIG] crm_partner_company_group: Migration to 16.0
c03ffa2
@adrianojprado @nguyenminhchien
Added translation using Weblate (Portuguese (Brazil))
33889c7
@mymage @nguyenminhchien
Added translation using Weblate (Italian)
1fb5775
@nguyenminhchien
[IMP] crm_partner_company_group: black, isort, prettier
0d1af43
@nguyenminhchien
[MIG] crm_partner_company_group: Migration to 17.0
9334123
@nguyenminhchien
[UPD] Update crm_partner_company_group.pot
1033029
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
4d13502
@weblate @nguyenminhchien
Update translation files
68d4f6e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-17.0/partner-contact-17.0-crm_partner_company_group
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-crm_partner_company_group/
@jdidderen-nsi @nguyenminhchien
[IMP] partner_contact_role: pre-commit execution
6706d4c
@nguyenminhchien
oca-port: blacklist PR(s) 1245 for crm_partner_company_group
5004822
@nguyenminhchien nguyenminhchien force-pushed the 18.0-mig-crm_partner_company_group branch from 10d7b6f to 19ecfaf Compare October 28, 2024 02:24
StefanRijnhart
StefanRijnhart reviewed Dec 2, 2024
View reviewed changes
crm_partner_company_group/hooks.py Outdated
env.execute(
"""
ALTER TABLE crm_lead
ADD COLUMN IF NOT EXISTS company_group_id integer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary anymore since odoo/odoo#65232, although I'm slightly wondering why this code does not actually populate the values. Is that on purpose?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StefanRijnhart, you're right. We don't need this hook anymore. I just removed it.

@nguyenminhchien nguyenminhchien force-pushed the 18.0-mig-crm_partner_company_group branch from 19ecfaf to c524ef4 Compare December 3, 2024 04:34
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart
StefanRijnhart approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1873-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f136070 into OCA:18.0 Dec 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dc99e46. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon approved these changes

@sebalix sebalix sebalix approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.