[18.0][MIG] base_location: Migration to 18.0 #1867

Kimkhoi3010 · 2024-10-15T09:14:38Z

No description provided.

simahawk · 2024-10-24T15:38:08Z

/ocabot migration base_location

simahawk

LG

simahawk · 2024-10-24T15:42:27Z

/ocabot merge nobump

OCA-git-bot · 2024-10-24T15:42:34Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1867-by-simahawk-bump-nobump, awaiting test results.

Signed-off-by simahawk

OCA-git-bot · 2024-10-24T15:43:49Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1867-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2024-10-24T15:44:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-10-24T15:46:23Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1867-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

TDu · 2024-10-28T14:14:55Z

@Kimkhoi3010 could you rebase this PR and check the pre-commit something probably has changed and the merging failed https://github.com/OCA/partner-contact/actions/runs/11502758305/job/32018465824
Thank you

TDu

Some changes needed on the view types !

TDu · 2024-10-28T14:34:19Z

base_location/views/res_city_zip_view.xml

+    <record id="action_zip_tree" model="ir.actions.act_window">
+        <field name="name">Locations</field>
+        <field name="res_model">res.city.zip</field>
+        <field name="view_mode">tree,form</field>


Suggested change

<field name="view_mode">tree,form</field>

<field name="view_mode">list,form</field>

TDu · 2024-10-28T14:34:49Z

base_location/views/res_city_view.xml

+        <field name="name">Cities</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="res_model">res.city</field>
+        <field name="view_mode">tree,form</field>


Suggested change

<field name="view_mode">tree,form</field>

<field name="view_mode">list,form</field>

I see this

when testing #1868 on runboat.

Hi @TDu, thank for your time!!

… when company country is filled.

…tter-zip field

…ssues with module partner_address_street3

…some views. Added two columns in respective tree views.

…ooks * Added Icon. * Improve module description and extracted to README.rst. * Pass country instead of country_id for advance comparisons. * Allow to transform city name. * Some code style. * Do not remove all entries of a country, but only not found. * Include hooks for transforming some things. * Include spanish translation.

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/fr/

Currently translated at 68.5% (24 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/pt_BR/

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/sv/

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/ca/

… the zip_id field to _address_fields() TT33047

pedrobaeza · 2024-10-30T18:44:25Z

base_location/models/res_partner.py

@@ -106,35 +106,35 @@ def _check_zip(self):
            error_dict = {"partner": rec.name, "location": rec.zip_id.name}
            if rec.zip_id.city_id.country_id != rec.country_id:
                raise ValidationError(
-                    _(
+                    self.env._(


AFAIK, there's no need to change this expression. Is there any reason to change it?

not strictly required but it offers a minor performance improvement, see odoo/odoo#174844

Thanks for the pointer. Adding this to the migration guide.

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-10-31T07:01:29Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1867-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-31T07:05:38Z

Congratulations, your PR was merged at 0196e10. Thanks a lot for contributing to OCA. ❤️

This was referenced Oct 15, 2024

Migration to version 18.0 #1856

Open

[18.0][MIG] base_location_geonames_import: Migration to 18.0 #1868

Merged

mmequignon approved these changes Oct 21, 2024

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Oct 24, 2024

simahawk approved these changes Oct 24, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 24, 2024

OCA-git-bot added a commit that referenced this pull request Oct 24, 2024

Merge PR #1867 into 18.0

5027c61

Signed-off-by simahawk

OCA-git-bot added the bot is merging ⏳ label Oct 24, 2024

OCA-git-bot added ready to merge and removed bot is merging ⏳ labels Oct 24, 2024

TDu reviewed Oct 28, 2024

View reviewed changes

Kimkhoi3010 force-pushed the 18.0-mig-base_location branch 2 times, most recently from 23361db to 5e1f1ee Compare October 29, 2024 03:08

nbessi and others added 10 commits October 29, 2024 10:11

[MV] rename better_zip to base_location

777306a

base_location: [IMP] Spanish translation and translation template.

20ba840

[FIX] mutable default in function signature

32be7b0

[FIX] base_location: Changed partner view to avoid extrange behaviour…

c559aa8

… when company country is filled.

[FIX] Add context propagation to base_location

a3d6393

[Add] Add italian translation, change field class to edit-only for be…

81abaf3

…tter-zip field

base_location: Don't position zip_id after street2, to avoid layout i…

0d17cf6

…ssues with module partner_address_street3

Danish translation

0c9897f

[IMP] base_location: Updated to v8 syntax and uses. Added filters in …

be2a104

…some views. Added two columns in respective tree views.

victor-champonnois and others added 19 commits October 29, 2024 10:11

Translated using Weblate (French)

7d30925

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/fr/

Translated using Weblate (Croatian)

5bd89b7

Currently translated at 68.5% (24 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/hr/

[UPD] README.rst

3b95595

Added translation using Weblate (French (Belgium))

7684c95

Update translation files

a1a90e9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/

Translated using Weblate (Italian)

ea54f53

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location/it/

[IMP] base_location: pre-commit stuff

c7e393f

[MIG] base_location: Migration to 17.0

46e3f29

[UPD] Update base_location.pot

e416d4a

[BOT] post-merge updates

0b98316

Update translation files

785fe34

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/

Translated using Weblate (Swedish)

82511ea

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/sv/

[IMP] partner_contact_role: pre-commit execution

67c0c2e

Translated using Weblate (Catalan)

2ff0038

Currently translated at 100.0% (35 of 35 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location/ca/

[IMP] base_location: pre-commit auto fixes

6063be6

[FIX] base_location: Since odoo/odoo#81239 it is not necessary to add…

b81f233

… the zip_id field to _address_fields() TT33047

oca-port: blacklist PR(s) , 1472 for base_location

b8ae16e

[MIG] base_location: Migration to 18.0

d964b09

Kimkhoi3010 force-pushed the 18.0-mig-base_location branch from 5e1f1ee to d964b09 Compare October 29, 2024 03:12

Kimkhoi3010 requested a review from TDu October 29, 2024 03:24

TDu approved these changes Oct 29, 2024

View reviewed changes

pedrobaeza reviewed Oct 30, 2024

View reviewed changes

pedrobaeza approved these changes Oct 31, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Oct 31, 2024

OCA-git-bot merged commit cb326b1 into OCA:18.0 Oct 31, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] base_location: Migration to 18.0 #1867

[18.0][MIG] base_location: Migration to 18.0 #1867

Kimkhoi3010 commented Oct 15, 2024

simahawk commented Oct 24, 2024

simahawk left a comment

simahawk commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

TDu commented Oct 28, 2024 •

edited

Loading

TDu left a comment

TDu Oct 28, 2024

TDu Oct 28, 2024

TDu Oct 28, 2024

Kimkhoi3010 Oct 29, 2024

pedrobaeza Oct 30, 2024

nilshamerlinck Oct 31, 2024

pedrobaeza Oct 31, 2024

pedrobaeza left a comment

OCA-git-bot commented Oct 31, 2024

OCA-git-bot commented Oct 31, 2024

	<field name="view_mode">tree,form</field>
	<field name="view_mode">list,form</field>

[18.0][MIG] base_location: Migration to 18.0 #1867

[18.0][MIG] base_location: Migration to 18.0 #1867

Conversation

Kimkhoi3010 commented Oct 15, 2024

simahawk commented Oct 24, 2024

simahawk left a comment

Choose a reason for hiding this comment

simahawk commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

OCA-git-bot commented Oct 24, 2024

TDu commented Oct 28, 2024 • edited Loading

TDu left a comment

Choose a reason for hiding this comment

TDu Oct 28, 2024

Choose a reason for hiding this comment

TDu Oct 28, 2024

Choose a reason for hiding this comment

TDu Oct 28, 2024

Choose a reason for hiding this comment

Kimkhoi3010 Oct 29, 2024

Choose a reason for hiding this comment

pedrobaeza Oct 30, 2024

Choose a reason for hiding this comment

nilshamerlinck Oct 31, 2024

Choose a reason for hiding this comment

pedrobaeza Oct 31, 2024

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 31, 2024

OCA-git-bot commented Oct 31, 2024

TDu commented Oct 28, 2024 •

edited

Loading